Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 1.4.2
    • 1.3, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5
    • base system
    • Yes

    Description

      I ran into some issues concerning the use of generics:

      public class RenderingModelImpl<RD extends RenderableDefinition> implements RenderingModel

      shouldn't this be

      public class RenderingModelImpl<RD extends RenderableDefinition> implements RenderingModel<RD>

      When this is fixed it would be nice to be able to subclass both STKTemplateModel and STKTemplate while being able to access operations on the STKTemplate subclass by getDefinition() on the model class. After the previous fix this would possible without braking anything.

      Change:

      public class STKTemplateModel extends RenderingModelImpl<STKTemplate>

      to

      public class STKTemplateModel<RD extends STKTemplate> extends RenderingModelImpl<RD>

      using this constructor:

      public STKTemplateModel(Content content, RD definition, RenderingModel parent)

      { super(content, definition, parent); }

      Checklists

        Acceptance criteria

        Attachments

          1. MGNLSTK-688-1.patch
            0.7 kB
          2. MGNLSTK-688-2.patch
            1 kB
          3. MGNLSTK-688-STK.patch
            4 kB
          4. MGNLSTK-688-Templating.patch
            0.8 kB
          5. RenderingModelImpl.java
            3 kB
          6. STKTemplateModel.java
            10 kB

          Issue Links

            Activity

              People

                fgrilli Federico Grilli
                roekoe Roelof Jan
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: