-
Improvement
-
Resolution: Done
-
Neutral
-
None
-
None
Background
During the extraction of the test-framework in MGNLCE-208 it was discovered that MagnoliaRestClient has public APIs that bring dependency to rest-services module which is not desired. For now in the extraction effort these APIs are deprecated, and in a future effort these APIs should be completely removed and the rest-services module dependency dropped.
Here is a comment from Mikaël Geljić on the PR.
These #readNode and #readProperty methods are not used in the context of the new test-framework.
Our main goal in porting MagnoliaRestClient over here is to keep supporting fixtures/cleanup. In fact, we could almost prune everything else.
The problem with these two methods in particular is that they return the original implementation types RepositoryNode & Property from rest-services module API, whereas we should be as much independent as possible here, so we can remove the maven dependency to rest-services as well. Modules will consume test-framework, not the other way around. (Worst case we can use a more primitive (map?) representation if needed).
Improvement Suggestions
Replace the rest-services usage in readNode/readProperty APIs of MagnoliaRestClient using REST delivery & REST-assured.
- depends upon
-
MGNLTEST-175 SaaS Integration Tests with the Test Framework
- In Progress
- relates to
-
MGNLTEST-1 Attempt to extract the integration test framework out of CE bundle
- Closed