Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-1290

Rename abstract action base classes and relocate action classes

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Major
    • 5.0
    • None
    • framework
    • Beta 3

    Description

      • ActionBase should be renamed to AbstractAction
      • RepositoryOperationAction should be renamed to AbstractRepositoryAction
      • CommandActionBase should be renamed to AbstractCommandAction
      • CommandActionBase should be moved from info.magnolia.ui.framework.app.action to be in the same package as AbstractRepositoryAction
      • ActivationAction, DeactivationAction and their definition classes should be moved from info.magnolia.ui.admincentral.activation.action to info.magnolia.ui.framework.action
      • The classes in info.magnolia.ui.admincentral.tree.action should be moved to info.magnolia.ui.framework.action
      • The actions CreateDialogAction, EditDialogAction and their definition classes in info.magnolia.ui.admincentral.dialog.action should move to info.magnolia.ui.framework.action

      Also make sure all tests are moved as well.

      Also, it could make sense to rename CreateDialogAction and EditDialogAction, to OpenCreateDialogAction and OpenEditDialogAction

      We also need to update documentation. We won't change dependencies for now although from a maven perspective depending on ui.framework would be enough for some modules now. The problem is that ui.framework is not a magnolia module so we couldn't adapt the module dependencies accordingly.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                dlipp Daniel Lipp
                tmattsson Tobias Mattsson
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR