-
Sub-task
-
Resolution: Fixed
-
Neutral
-
5.1
-
None
-
None
-
-
5.1 - Final
From review document:
Detail Editor
CLZ
info.magnolia.ui.contentapp.detail.DetailEditorPresenter#CONTENTAPP_BASENAME should go away (not used, not needed)
DetailEditorPresenter message formatting in catch blocks
info.magnolia.ui.contentapp.detail.DetailPresenter#i18nizer - injected deps should be final
but is actually not used in this specific case
info.magnolia.ui.contentapp.detail.DetailSubApp#setCaption uses a pages-app key, but isn't specific to pages app
BaseDialogPresenter: #decorateForI18n
//TODO Christopher Zimmermann - Verify that this is still necessary.
--> it is not. (CLZ says - I think the tests are OK.)
It's only used in tests (Which are probably broken, since they test sthg that isn't used)
Improve calls to SimpleTranslator
info.magnolia.security.app.action.AbstractDeleteGroupOrRoleAction
#getI18n probably not relevant
CLZ
security.delete.group.or.role.group this key is really poorly named. (security.delete.group ?)
#getUsersAndGroupsThisItemIsAssignedTo does some suspicious concatenation, should use formatting, and the 2 keys are probably completeley redundant (use formatting too)