Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2131 i18n: use new i18n for all text in Magnolia - Master Ticket
  3. MGNLUI-2210

i18n fixes: Improvements to ContentApp, BaseDialogPresenter, AbstractDeleteGroupOrRoleAction

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.1
    • 5.1
    • None
    • None
    • 5.1 - Final

      From review document:

      Detail Editor
      CLZ
      info.magnolia.ui.contentapp.detail.DetailEditorPresenter#CONTENTAPP_BASENAME should go away (not used, not needed)

      DetailEditorPresenter message formatting in catch blocks
      info.magnolia.ui.contentapp.detail.DetailPresenter#i18nizer - injected deps should be final
      but is actually not used in this specific case

      info.magnolia.ui.contentapp.detail.DetailSubApp#setCaption uses a pages-app key, but isn't specific to pages app

      BaseDialogPresenter: #decorateForI18n
      //TODO Christopher Zimmermann - Verify that this is still necessary.
      --> it is not. (CLZ says - I think the tests are OK.)
      It's only used in tests (Which are probably broken, since they test sthg that isn't used)

      Improve calls to SimpleTranslator
      info.magnolia.security.app.action.AbstractDeleteGroupOrRoleAction
      #getI18n probably not relevant
      CLZ
      security.delete.group.or.role.group this key is really poorly named. (security.delete.group ?)
      #getUsersAndGroupsThisItemIsAssignedTo does some suspicious concatenation, should use formatting, and the 2 keys are probably completeley redundant (use formatting too)

            czimmermann Christopher Zimmermann
            czimmermann Christopher Zimmermann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: