• Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.1
    • 5.1
    • None
    • None
    • 5.1 - Final

      https://docs.google.com/document/d/1FTEG7kQcIYhRcuOhsiN3lY2D1P83cdXH9RVtpCS5u8U/edit#

      info.magnolia.ui.framework.app.AppInstanceControllerImpl#start (5.1)
      Message subject is supposed to be formatted but really isn't
      "ui-framework.app.appinstance.memory-limit-warning.message" is not translated anywhere

      info.magnolia.monitoring.SystemMonitor#MEMORY_LIMIT_IS_REACHED_STRING_FORMAT
      should be a key
      info.magnolia.security.app.dialog.field.WorkspaceAccessFieldFactory (5.1)
      didn't have @Inject, why does it need it now ?
      #componentProvider - unused

      info.magnolia.security.app.dialog.action.SaveUserDialogAction#i18n should be private !
      is only used to translate an exception that should probably never occur anyway ? (i.e ActionAvailability should prevent it from being available on root)
      5.1 If the above assumption is correct (AA prevents this from happening in normal situations), remove i18n from this completely, no need to trasnalte systen exceptions)

            czimmermann Christopher Zimmermann
            czimmermann Christopher Zimmermann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: