Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2701

Multiple submissions of single publication possible within pages app, producing erroneous change requests

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.2
    • Fix Version/s: 5.2.7, 5.3
    • Component/s: page editor
    • Security Level: Public
    • Environment:
      OSX, Safari, Chrome etc

      Description

      When executing the Publish action within the pages app, you can (quickly) click on the 'SAVE CHANGES' button more than once before the 'Submit for publication' dialog is submitted.

      This will result in more than one publish request, one of which will fail due to no 'version' being found in the JCR:

      javax.jcr.version.VersionException: Version {}1.100 does not exist.
      at org.apache.jackrabbit.core.version.InternalVersionHistoryImpl.getVersion(InternalVersionHistoryImpl.java:277)
      at org.apache.jackrabbit.core.version.VersionHistoryImpl.getVersion(VersionHistoryImpl.java:138)
      at info.magnolia.cms.core.version.BaseVersionManager.getVersion(BaseVersionManager.java:335)
      at info.magnolia.cms.core.DefaultContent.getVersionedContent(DefaultContent.java:500)

        Issue Links

          Activity

          Hide
          dlipp Daniel Lipp added a comment -

          Hi Dean,

          As you might have realized I moved that ticket to MGNLUI.

          Thx for reporting
          Daniel

          Show
          dlipp Daniel Lipp added a comment - Hi Dean, As you might have realized I moved that ticket to MGNLUI. Thx for reporting Daniel
          Hide
          runger Richard Unger added a comment -

          +1

          Show
          runger Richard Unger added a comment - +1
          Hide
          had Jan Haderka added a comment -

          maybe the default behaviour should be changed showing user message asking if they really want to publish the page since nothing has changed since last publication (when page is already marked as activated and not modified).

          Show
          had Jan Haderka added a comment - maybe the default behaviour should be changed showing user message asking if they really want to publish the page since nothing has changed since last publication (when page is already marked as activated and not modified).
          Hide
          runger Richard Unger added a comment -

          To be honest, what we would really want here is direct feedback for the user that prevents him invoking the unneeded action in the first place. Something like:

          --> when user chooses publish, the icon(s) for the content being published change from red (or yellow) to 'spinner'
          --> when publish command completes, the icon changes from 'spinner' to:

          • if activation is complete, status changes to green
          • if activation is pending workflow completion (ie content is in workflow) icon changes to a 'clock'-style icon to signify content is in workflow
            --> tooltips on the icons give textual description of state

          in other words the concept of "activation status", at least in terms of display in the UI, needs to get a bit more complicated, and explicitly accommodate and display the "in Workflow" status.

          Show
          runger Richard Unger added a comment - To be honest, what we would really want here is direct feedback for the user that prevents him invoking the unneeded action in the first place. Something like: --> when user chooses publish, the icon(s) for the content being published change from red (or yellow) to 'spinner' --> when publish command completes, the icon changes from 'spinner' to: if activation is complete, status changes to green if activation is pending workflow completion (ie content is in workflow) icon changes to a 'clock'-style icon to signify content is in workflow --> tooltips on the icons give textual description of state in other words the concept of "activation status", at least in terms of display in the UI, needs to get a bit more complicated, and explicitly accommodate and display the "in Workflow" status.
          Hide
          had Jan Haderka added a comment -

          removed. thx for spotting it.

          Show
          had Jan Haderka added a comment - removed. thx for spotting it.
          Hide
          hudson Hudson CI Server added a comment -

          SUCCESS: Integrated in magnolia_ui #2967
          MGNLUI-2701 disable button in dialog on click (Jan Haderka: rev 1b3cb8a408c690fc161fa126db3895674b1cde77)

          Show
          hudson Hudson CI Server added a comment - SUCCESS: Integrated in magnolia_ui #2967 MGNLUI-2701 disable button in dialog on click (Jan Haderka: rev 1b3cb8a408c690fc161fa126db3895674b1cde77)
          Hide
          mgeljic Mikaël Geljic added a comment -

          Alright, QA was done successfully, just reopening by the time it gets integrated to 5.2.x. — that is most likely after 5.2.5 is out. I updated fixVersion accordingly.

          Show
          mgeljic Mikaël Geljic added a comment - Alright, QA was done successfully, just reopening by the time it gets integrated to 5.2.x. — that is most likely after 5.2.5 is out. I updated fixVersion accordingly.
          Hide
          hudson Hudson CI Server added a comment -

          SUCCESS: Integrated in magnolia_ui-5.2.x-branch #120
          MGNLUI-2701 disable button in dialog on click (jsimak: rev 7878649ac0168ebc0b3e9a18364da74c04866184)

          Show
          hudson Hudson CI Server added a comment - SUCCESS: Integrated in magnolia_ui-5.2.x-branch #120 MGNLUI-2701 disable button in dialog on click (jsimak: rev 7878649ac0168ebc0b3e9a18364da74c04866184)

            People

            • Assignee:
              jsimak Jaroslav Simak
              Reporter:
              dean.pullen Dean Pullen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: