Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2714

FormDialogPresenter does not i18n-decorate the definition correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.2.2
    • Fix Version/s: 5.2.3
    • Component/s: None
    • Labels:
      None
    • Magnolia Release:
      5.2.3

      Description

      Actions on FormDialogs are currently not decorated for i18n.
      The reason is in these two methods:

      • info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl#start(final Item item, FormDialogDefinition dialogDefinition, final UiContext uiContext, EditorCallback callback)
        the definition is set and decorated in the super method and is accessible using the getter, but instead of getting the decorated definition, we set the undecorated object to the action executor.
      • info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl#buildView
        instead of passing the decorated definition, we re-decorate the passed parameter.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ejervidalo Espen Jervidalo
              Reporter:
              ejervidalo Espen Jervidalo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: