Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2853

Cleanup AvailabilityChecker, shorthand rules, tests

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 5.3
    • 5.3
    • content app
    • None

    Description

      During QA of MGNLUI-2778, I found that some code in AvailabilityCheckerImpl, shorthand AvailabilityRules and AvailabilityCheckerTest can be cleaned up a bit, in particular:

      • Shorthand rule classes can be named more consistently
      • Constructors of such AvailabilityRules can be removed, especially those taking non-primitive types as param.
      • Simplify/streamline javadoc
      • AvailabilityCheckerTest should be renamed to -ImplTest, underscores in method names should be removed and dummy rules should be moved to nested classes.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR