Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2853

Cleanup AvailabilityChecker, shorthand rules, tests

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.3
    • 5.3
    • content app
    • None
    • 5.3 Sprint 5, 5.3 Sprint 6

      During QA of MGNLUI-2778, I found that some code in AvailabilityCheckerImpl, shorthand AvailabilityRules and AvailabilityCheckerTest can be cleaned up a bit, in particular:

      • Shorthand rule classes can be named more consistently
      • Constructors of such AvailabilityRules can be removed, especially those taking non-primitive types as param.
      • Simplify/streamline javadoc
      • AvailabilityCheckerTest should be renamed to -ImplTest, underscores in method names should be removed and dummy rules should be moved to nested classes.

        Acceptance criteria

              mgeljic Mikaël Geljić
              mgeljic Mikaël Geljić
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: