Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3735

AbstractCommandsAction should not force params for commands

    XMLWordPrintable

Details

    • Bug
    • Resolution: Obsolete
    • Neutral
    • None
    • None
    • None
    • Yes
    • 1

    Description

      Specially since it doesn't provide subclasses w/ any means to set the map itself (it is initialised as unmodifiable collection in onPreExecute() and filled in w/ just the id of item making it pretty useless. Plus not every command requires any parameters in a first place.

      Attached patch adds null check when building unmodifiable collection to prevent NPE in case onPreExecute() is overwritten, but still doesn't expose map to the subclasses.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              had Jan Haderka
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD