Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3735

AbstractCommandsAction should not force params for commands

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Obsolete
    • Icon: Neutral Neutral
    • None
    • None
    • None
    • Yes
    • 1

      Specially since it doesn't provide subclasses w/ any means to set the map itself (it is initialised as unmodifiable collection in onPreExecute() and filled in w/ just the id of item making it pretty useless. Plus not every command requires any parameters in a first place.

      Attached patch adds null check when building unmodifiable collection to prevent NPE in case onPreExecute() is overwritten, but still doesn't expose map to the subclasses.

        Acceptance criteria

          1. patch.txt
            1 kB

              Unassigned Unassigned
              had Jan Haderka
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD