Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-374

ContactLinkFieldBuilder should configure its ImageProvider with the config in its subapps workbench definition

    XMLWordPrintable

Details

    Description

      This is a followup task to MGNLUI-370. To fix 370 (where the ImageProvider could not be injected) a new ImageProviderDefinition configuration was hard coded in ContactLinkFieldBuilder. It should not be hard coded, it should be retrieved from the workbench definition of the contacts main sub app.

      Resolving this issue may be as simple as retrieving the configuration information in a clean way. But I was not able to see an obvious way for a LinkFieldBuilder to get workbench config of it's sub app. So the solution could be to change the framework such that this information is available.

      One lead is that perhaps the ContactLinkFieldDefinition or the LinkFieldDefinition could be extended to store the workbench definition.

      Or maybe the workbench definition does not need to be added, maybe it would be enough to make the ContactLinkFieldDefinition include an ImageProviderDefinition. More evaluation needed.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                czimmermann Christopher Zimmermann
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD