Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3863

After creating nodes with (invalid) characters, such as commercial/at/@ Magnolia apps might crash when addressing such nodes

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 5.4.8
    • None
    • None
    • Kromeriz 51
    • 8

    Description

      Commercial at (@) is currently forbidden character in node name. Forbidden by Magnolia that is, for historical reasons, see more at https://documentation.magnolia-cms.com/display/DOCS/Managing+pages#Managingpages-Invalidcharacters.

      Due to those characters being historically forbidden by Magnolia, there are various parts that do not handle such chars well as it was not required in the past. Said commercial character is however no longer treated consistently and most apps allow it's use as node or property name.

      Without changing functionality of Magnolia where commercial is allowed on purpose (user subapp), we need to treat nodes with commercial consistently. Therefore:

      • AddNodeAction should validate label name and not create node with invalid name
      • SaveRoleDialogAction should create roles with valid node names
      • JcrContentConnector should not fail on NPE when node contains @
      • remove duplicated code between JcrContentConnector and JcrItemUtil

      Once we MGNLUI-322 is resolved, commercial character can be enabled again for all apps, by simply removing it from the validation method and enabling it in all places at once.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mdivilek Milan Divilek
                zdenekskodik Zdenek Skodik
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 0.5h
                      0.5h