Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3920

Remove changedProperties from adapters upon #removeItemProperty

    XMLWordPrintable

Details

    • Saigon 54
    • 3

    Description

      Currently, if we #addItemProperty and then #removeItemProperty on the adapter, before saving, it will still try to save the changed property (it's not removed from the map).

      If we blindly do this, we then run into concurrent access, because #updateProperty (internal API) also calls #removeItemProperty (public Vaadin API) when value is blank. Then it's too late to act upon #changedProperties so we need to mark properties for deletion "internally" as well.

      Use case/story:
      Only the Item is passed from the FieldFactory to the Form to the SaveDialogAction.
      So this simply allows us to carry arbitrary transient properties (with arbitrary type) along with the adapter, without the intention to save them to JCR (by the time we replace that with some form execution context in 5.5).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - 1h
                      1h
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 1h
                      1h