Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3973

After zip import, location points to non-existing /untitled node, shows multi-item actionbar section

    XMLWordPrintable

    Details

    • Release notes required:
      Yes
    • Sprint:
      Saigon 59
    • Story Points:
      3
    • Magnolia Release:
      5.4.9, 5.5

      Description

      Similarly to linked ticket MGNLUI-3950, UI selection status is a bit inconsistent after a zip import action.

      Current proposal is to create a folder with the zip file name and select/expand this one; should be a reasonable behavior change.


      Former issue title and description:
      Expand, collapse then expand the sibling of node which has just imported causes NPE

      Steps to reproduce:

      • Access any apps has import action with tree view like pages, config app
      • Select root node
      • Import a node
      • Expand sibling node (modules in config app) then collapse it, then expand again. You will see an error.

      Here is error log:

      com.vaadin.event.ListenerMethod$MethodException: Invocation of method nodeCollapse in info.magnolia.ui.workbench.tree.TreeViewImpl$CollapsedNodeListener failed.
      	at com.vaadin.event.ListenerMethod.receiveEvent(ListenerMethod.java:528)
      	at com.vaadin.ui.TreeTable.fireCollapseEvent(TreeTable.java:856)
      	at com.vaadin.ui.TreeTable.toggleChildVisibility(TreeTable.java:569)
      	at com.vaadin.ui.TreeTable.changeVariables(TreeTable.java:429)
      	at info.magnolia.ui.vaadin.grid.MagnoliaTreeTable.changeVariables(MagnoliaTreeTable.java:86)
      ...
      Caused by: java.lang.NullPointerException
      	at info.magnolia.ui.workbench.tree.TreeViewImpl.isDescendantOf(TreeViewImpl.java:289)
      	at info.magnolia.ui.workbench.tree.TreeViewImpl.unselectDescendants(TreeViewImpl.java:274)
      	at info.magnolia.ui.workbench.tree.TreeViewImpl.access$500(TreeViewImpl.java:68)
      	at info.magnolia.ui.workbench.tree.TreeViewImpl$CollapsedNodeListener.nodeCollapse(TreeViewImpl.java:266)
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              oanh.thai Oanh Thai Hoang
              Reporter:
              sang.ngo Sang Ngo Huu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response:

                  Time Tracking

                  Estimated:
                  Original Estimate - 3d
                  3d
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1d 7h Time Not Required
                  1d 7h