Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-405

AppDescriptorRegistry only fires change events when name, enabled, icon or app class is changed

    XMLWordPrintable

Details

    • Task
    • Resolution: Outdated
    • Neutral
    • None
    • 5.0
    • app framework

    Description

      When you change configuration of an app, for instance within a sub app or its permissions or something else the AppDescriptorRegistry does not fire events. It only fires event if any of name, enabled, icon or appClass is change.

      AppDescriptorRegistry performs checks on the app providers it has registered in order to send very fine grained events. It relies on providers implementing the equals method to compare them as they are registered. These fine grained events are all processed identically and so don't seem to be necessary.

      Simplifying this would mean that we instead of firing REGISTERED,REREGISTERED,UNREGISTERED would fire a single event meaning that the set of app descriptors has changed.

      This concerns the classes:

      • info.magnolia.ui.framework.app.registry.AppDescriptorRegistry
      • info.magnolia.ui.framework.app.registry.AppRegistryEvent
      • info.magnolia.ui.framework.app.registry.AppRegistryEventType
      • info.magnolia.ui.framework.app.registry.AppRegistryEventHandler

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                tmattsson Tobias Mattsson
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR