Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4057

DialogMigrationTask uses new package for (Save+Cancel)DialogActionDefinition and causes migration diffs

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 5.5
    • None
    • None
    • None

    Description

      info.magnolia.ui.dialog.setup.DialogMigrationTask was used in post-4.5 era to migrate legacy dialogs to the new UI. The task is mainly used in modules' MVH of that time, for example standard-templating-kit version 2.5 would migrate its dialogs using this task.

      In MGNLUI-4022 this legacy task was updated to use the new packages of the moved SaveDialogActionDefinition and CancelDialogActionDefinition! (info.magnolia.ui.dialog.action.SaveDialogActionDefinitioninfo.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition).

      This causes migrated instances to already contain the new actions when migrating from 4.5 to 5.5!

      Instead, this task should not have been touched. We should maybe create a new task for the pupose of updating the action (if necessary at all, there is info.magnolia.module.delta.ChangeAllPropertiesWithCertainValueTask)!?

      Task

      Partially revert changes made to info.magnolia.ui.dialog.setup.DialogMigrationTask.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pmundt Philip Mundt
                pmundt Philip Mundt
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD