Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5625

Harmonize nodeType configuration for definitions

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 6.2
    • None
    • None
    • None

    Description

      Background: While fixing the issue MGNLUI-5624, it was discovered that publish incl. subpages action was unavailable on dx-core, but available on ce. Upon further investigation it was found, that this behavior was due to incorrect nodeType configuration in pages-app decorator in personalization-pages-app module in dx-core. The nodeType configuration expected by the info.magnolia.ui.availability.rule.JcrHasChildrenRuleDefinition was a list of strings, but the decoration provided a list of NodeType Objects of the form:

      nodeTypes:
        - name: mgnl:page
        - name: mgnl:variants
      

      It was further noted that other nodeType configurations in personalization-pages/decorations/pages-app/apps/pages-app.yaml were of the form of List of NodeType objects. As a consequence, there are two things that need to be analyzed and fixed:

      • So, there are In order to avoid confusion, maintain consistency, and avoid a source of potential bugs in configuration of nodeTypes, all nodeTypes should be maintained as a single type
      • Fix the bugs in configurations where nodeTypes property configured is not of the same type as expected by the Definition

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              rdhar Rishab Dhar
              rdhar Rishab Dhar
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoR