-
Improvement
-
Resolution: Unresolved
-
Neutral
-
None
-
6.1, 6.2
-
None
-
None
-
Message Banner should be clean up
Following discussion about NPE throwing when using Shell.showError
Here are some improvement suggestions:
- Deprecated #showError and #showNotification API in shell. See here
- The Banner component deserves cleanup.
- Remove all of these Objects#requireNonNull and Preconditions#checkArgument: null values should become empty strings gracefully. If we want to have such checks, they should be on MessagesManager level, not UI component.
- remove the #setId on line 135
Acceptance criteria