Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5892

I18nisation of search results broke file-based search result suppliers

    XMLWordPrintable

Details

    • Bug
    • Resolution: Not an issue
    • Critical
    • None
    • 6.2.1
    • None
    • None

    Description

      To Reproduce:

      1)

      • Define a custom search result supplier and name it with a random name 'xyz.yaml'
      • Do a search in the UI and see NPEs at info.magnolia.admincentral.findbar.SearchResultsGrid#getI18nizedSupplierLabel

      2)

      • Use external-dam module or e-commerce module
      • Do a search in the UI and see NPEs at info.magnolia.admincentral.findbar.SearchResultsGrid#getI18nizedSupplierLabel

        

       

      DEV Hints:

      • The fix should be provided by iterating over the definitions and matching the correct one
      • Trying to fetch with Registry#provider won't work because the id is the file name vs search result has a different type
        • Xyz vs 'product'
      • Write unit tests

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                ilgun Ilgun Ilgun
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 5m
                      5m