Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-6306

Investigate the need for supporti18n property in non-deprecated context

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 6.2.7
    • None
    • None
    • None
    • Yes
    • UI FW 22
    • 1

    Description

      Current situation

      Definition is not checked for supporti18n in info.magnolia.ui.editor.JcrIndexedChildNodeProvider#constructTargetSubNodeName the same way it is checked in info.magnolia.ui.editor.JcrChildNodeProvider#constructTargetSubNodeName
       
      It seems like info.magnolia.ui.editor.JcrChildNodeProviderDefinition#supportI18N was introduced for compatibility purposes but leaks to new UI.

      Desired situation

      I18n logic should likely rely on i18n of ConfiguredComplexPropertyDefinition instead of supporti18n (or rely on i18n config of when using the childNodeProvider)

      There are now three ways of configuring i18n in, e.g., a multi.

      • On the inner field level,
      • on the multi-field level, and also
      • on the child provider level. The third one should not be made available. We need to test what consequences would use of it introduce. (consider if the fact that it's released means we cannot remove it anymore)

      Write a test for the behavior of this. 

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                sdemocko Šimon Demočko
                sdemocko Šimon Demočko
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 40m
                      40m