Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Investigate the need for supporti18n property in non-deprecated context

Description

Current situation

Definition is not checked for supporti18n in info.magnolia.ui.editor.JcrIndexedChildNodeProvider#constructTargetSubNodeName the same way it is checked in info.magnolia.ui.editor.JcrChildNodeProvider#constructTargetSubNodeName
 
It seems like info.magnolia.ui.editor.JcrChildNodeProviderDefinition#supportI18N was introduced for compatibility purposes but leaks to new UI.

Desired situation

I18n logic should likely rely on i18n of ConfiguredComplexPropertyDefinition instead of supporti18n (or rely on i18n config of when using the childNodeProvider)

There are now three ways of configuring i18n in, e.g., a multi.

  • On the inner field level,

  • on the multi-field level, and also

  • on the child provider level. The third one should not be made available. We need to test what consequences would use of it introduce. (consider if the fact that it's released means we cannot remove it anymore)

Write a test for the behavior of this. 

Activity

Show:

Deactivated User February 17, 2021 at 1:34 PM

Šimon Demočko February 17, 2021 at 11:32 AM

checked Release notes again as per https://magnolia-cms.slack.com/archives/DQB8U1ZM4/p1613561328004900?thread_ts=1613560858.002700&cid=DQB8U1ZM4 

From Ashraf to release doc person: It should probably say something along the lines of: "With this release, the supportI18N property has been deprecated. Setting supportI18N to false is still necessary in certain compatibility configurations (for example, when porting configurations
that use Magnolia 5 UI multi field transformers)."

Šimon Demočko February 16, 2021 at 11:56 AM

Removed release notes and documentation update required because of split to DOCU-2129

Šimon Demočko February 8, 2021 at 9:53 AM

The field was introduced only to support reading data from old Magnolia. You can see an example [here|https://docs.magnolia-cms.com/product-docs/Releases/Release-notes-for-Magnolia-CMS-6.2.1.html#_new_supporti18n_property_in_jcrchildnodeprovider.]]. 

In new Magnolia, the usage of this property should be clearly marked as deprecated. This should have also been marked in https://docs.magnolia-cms.com/product-docs/Releases/Release-notes-for-Magnolia-CMS-6.2.1.html#_new_supporti18n_property_in_jcrchildnodeprovider, consult possibility of adding the deprecation note retroactively or mark it as deprecated now and note in new release notes. Otherwise, the release notes sound as if this was a new feature we introduced we're okay with customers using (though we don't have documentation for it).

Implementation-wise, there's nothing we can do about it at the moment, it needs to stay there as long as we support reading and writing such structures.

We should mark the property as deprecated though. 

Fixed

Details

Assignee

Reporter

Priority

Fix versions

Parent

Story Points

Sprint

More fields

Created October 9, 2020 at 2:44 PM
Updated February 18, 2021 at 7:05 AM
Resolved February 17, 2021 at 8:15 AM