-
Task
-
Resolution: Unresolved
-
Neutral
-
None
-
None
-
None
-
None
When work from the SaaS feature branch was made into the new master branch for UI, the following binary compatibility errors showed up and were allowed:
WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiMethod [oldMethod=info.magnolia.ui.mediaeditor.definition.MediaEditorDefinition.getId(), newMethod=n.a., returnType=JApiReturnType [oldReturnTypeOptional=java.lang.String, newReturnTypeOptional=value absent, changeStatus=REMOVED], getCompatibilityChanges()=[METHOD_REMOVED]] May 09, 2022 9:49:33 PM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiMethod [oldMethod=info.magnolia.ui.mediaeditor.definition.MediaEditorDefinition.setId(java.lang.String), newMethod=n.a., returnType=JApiReturnType [oldReturnTypeOptional=void, newReturnTypeOptional=value absent, changeStatus=REMOVED], getCompatibilityChanges()=[METHOD_REMOVED]]May 10, 2022 8:02:28 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiConstructor [oldConstructor=javassist.CtConstructor@35302e94[public BasicI18NAuthoringSupport ()V], newConstructor=value absent, getNewConstructor()=value absent, getOldConstructor()=javassist.CtConstructor@35302e94[public BasicI18NAuthoringSupport ()V], getCompatibilityChanges()=[CONSTRUCTOR_REMOVED]]May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiImplementedInterface [fullyQualifiedName=com.vaadin.event.ContextClickEvent$ContextClickNotifier, changeStatus=REMOVED, compatibilityChanges=[INTERFACE_REMOVED]] May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiImplementedInterface [fullyQualifiedName=com.vaadin.event.MethodEventSource, changeStatus=REMOVED, compatibilityChanges=[INTERFACE_REMOVED]] May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiImplementedInterface [fullyQualifiedName=com.vaadin.ui.HasComponents, changeStatus=REMOVED, compatibilityChanges=[INTERFACE_REMOVED]] May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiImplementedInterface [fullyQualifiedName=java.lang.Iterable, changeStatus=REMOVED, compatibilityChanges=[INTERFACE_REMOVED]] May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiSuperclass [jApiClass=JApiClass [fullyQualifiedName=info.magnolia.admincentral.usermenu.UserMenu, changeStatus=MODIFIED, compatibilityChanges=[CLASS_NOW_ABSTRACT, CLASS_TYPE_CHANGED]], oldSuperclass=com.vaadin.ui.Composite, newSuperclass=java.lang.Object, changeStatus=MODIFIED, compatibilityChanges=[SUPERCLASS_REMOVED]] May 10, 2022 10:34:41 AM japicmp.output.incompatible.IncompatibleErrorOutput warn WARNING: Incompatibility detected: Requires semantic version level MAJOR: JApiClass [fullyQualifiedName=info.magnolia.admincentral.usermenu.UserMenu, changeStatus=MODIFIED, compatibilityChanges=[CLASS_NOW_ABSTRACT, CLASS_TYPE_CHANGED]]
Maybe in some cases it may make sense for customers to properly deprecate rather than go for the breaking change. The goal of this ticket is to evaluate that.
Acceptance criteria
- is related to
-
BUILD-785 Allow binary compatibility exceptions such as removal of methods in new Magnolia majors such as 6.3
- Closed