Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-7954

Make a Notification provider injectable

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Neutral Neutral
    • 6.3.0, 6.2.31
    • None
    • None
    • None

      Steps to reproduce

      Expected results

      Test/build always passes.

      Actual resultshttps://jenkins.magnolia-cms.com/blue/organizations/jenkins/platform%2Fui/detail/PR-2350/21/pipeline#step-421-log-1152

      [ERROR] RowDraggerTest.showWarningMessageWhenDropConstraintIsNotAllowedAt:129 » NullPointer Cannot invoke "com.vaadin.server.AbstractClientConnector.addExtension(com.vaadin.server.Extension)" because "target" is null

      Workaround

      Re-trigger the build until the build is successful.

      Development notes

      The failures are more often after update of a junit runner. There don't seem to be any previous tests which would not clean a resources. It might be connected to reusing threads etc.

      As the investigation of the cause was not successful we suggest to avoid static Vaadin calls to show notifications which would make testing easier.

      We replace usages of Notification.show only in classes with no public ctors. The rest can be tackled when the constructors need to be changed.

        Acceptance criteria

          1.
          Implementation Sub-task To Do Unassigned
          2.
          Review Sub-task To Do Unassigned
          3.
          Pre-Integration QA Sub-task To Do Unassigned
          4.
          QA Sub-task To Do Unassigned

              Unassigned Unassigned
              rkovarik Roman Kovařík
              Thomas Duffey
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD