Uploaded image for project: 'Magnolia Vaadin Compatibility Addons'
  1. Magnolia Vaadin Compatibility Addons
  2. MGNLVA-5

Updating Vaadin to version 8.8.2 causes compilation issues

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.3
    • None
    • None

    Description

      While in the scope of MGNLUI-5119 I tried to update Vaadin to 8.8.2 in compatibility addons too. This caused

      Compilation failure
      [ERROR] /Users/fgrilli/devel/workspace/magnolia/vaadin-compatibility-addons/vaadin-compatibility-context-menu/src/main/java/com/vaadin/contextmenu/client/MyVOverlay.java:[22,24] setApplicationConnection(com.vaadin.client.ApplicationConnection) in com.vaadin.contextmenu.client.MyVOverlay cannot override setApplicationConnection(com.vaadin.client.ApplicationConnection) in com.vaadin.client.ui.VOverlay
      [ERROR]   overriding method is static
      

      due to a workaround used by https://github.com/vaadin/context-menu in version 2.0.0 which is no longer compatible with the latest Vaadin.
      Trying to update the addon to its latest 3.0.0 version, a complete rewrite (still with an API backward compatibility, so they claim), fails to apply some patch of ours.

      It is no so clear, at least to me, how that patch should be changed, nor if it is actually still needed.
      Failing to fix this has repercussions on the widgetset compilation which fails with a message similar to the one mentioned above.

      Finally, given the update to Vaadin 8.8.2 the addons version will probably need a bump to 1.3

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                asiska Adam Siska
                fgrilli Federico Grilli
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD