Uploaded image for project: 'Websphere Commerce Integration'
  1. Websphere Commerce Integration
  2. MGNLWCS-77

Do not hardcode FormProcessorFailedException message

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.0.1, 1.1
    • None
    • None
    • None

    Description

      info.magnolia.wcs.integration.form.PersonUpdateFormProcessor#personServiceCall
      info.magnolia.wcs.integration.form.PersonRegistrationFormProcessor#personServiceCall
      info.magnolia.wcs.integration.form.AddressBookFormProcessor#newAddressActionProcess
      info.magnolia.wcs.integration.form.AddressBookFormProcessor#editAddressActionProcess
      info.magnolia.wcs.integration.form.AddressBookFormProcessor#removeAddressActionProcess
      ...

      All these methods have hardcoded error message if rest service call failed. Instead of hardcoded message we should use error message from rest service which contains reason why call failed.

      e.getResponse().readEntity(ObjectNode.class).findValue("errorMessage").asText();
      

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              mdivilek Milan Divilek
              mdivilek Milan Divilek
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD