Uploaded image for project: 'Magnolia Workflow Module'
  1. Magnolia Workflow Module
  2. MGNLWORKFLOW-356

Incorrect displaying of the changes when comparing versions (backport)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • 5.5.6
    • 5.5.5
    • Base
    • None

    Description

      Steps to reproduce:

      1. Make some changes to the pages and submit for publish. (Req1)
      2. Again submit the same page for publish without making any changes. (req2)
      3. Now make another change on a different component in the same page and submit for approval. (Res 3)
      4. Check the notifications tab and you can see 3 requests for approval for the same page.
      5. Now click on Req1 and say show changes.

      Expected:
      The changes made first should only be displayed.

      Actual:
      Changes made as part of third request is highlighted as the changes. So the approver cannot actually know what has been changed in this version and in the next versions.


      After a bit of investigation the problem seems to be at info.magnolia.module.workflow.action.WorkItemLocalizedDiffAction#getLocation #61 et seq. The diff URL is built there always starting from the last version and comparing it with the previous one. No matter how many versions you have in there the last two are compared.

      Solution consists in comparing the version created with a given publication request with its previous version, if one exists.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                fgrilli Federico Grilli
                evystup Ervin Vystup
                AuthorX
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Bug DoR
                    Task DoD