Uploaded image for project: 'Magnolia Templating Essentials'
  1. Magnolia Templating Essentials
  2. MTE-41

Add component ThemeDelegatingImagingSupport that will delegate to theme's imaging support replacing the DefaultImagingSupport

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 0.6
    • None
    • imaging
    • None
    • Sprint 7 (Basel)
    • 1

      When using the mte-imaging module, the system-wide component for ImagingSupport is still the DefaultImagingSupport, which is injected in different other classes. Especially the info.magnolia.imaging.functions.ImagingTemplatingFunctions use the ImagingSupport, resulting in the following behavior:

      Even when a theme + imaging support and variations are configured will the DefaultImagingSupport be used always returning the original image instead of variations of it (when calling info.magnolia.imaging.functions.ImagingTemplatingFunctions#getImageVariationLinkFromBinary(javax.jcr.Node, java.lang.String)).

      Solution

      Provide a ThemeDelegatingImagingSupport that delegates to the theme's imaging support and falls back to the DefaultImagingSupport when no theme can be found.

        Acceptance criteria

              pmundt Philip Mundt
              pmundt Philip Mundt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 1.5h
                    1.5h