Uploaded image for project: 'Magnolia Multisite Module'
  1. Magnolia Multisite Module
  2. MULTISITE-180

Default port is added for https links

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 2.1.3
    • 2.1.2
    • None

      A pull request for this issue has been created at https://git.magnolia-cms.com/projects/ENTERPRISE/repos/multisite/pull-requests/79/overview

       

      info.magnolia.multisite.DomainNamePathTransformer is used to create fully qualified links. The current implementation unnecessarily appends the default port number (443) for https links

      Steps to reproduce

      1. create a site with protocol == https and port == 443
      2. generate a link using info.magnolia.multisite.DomainNamePathTransformer

      Expected results

      it should return i.e. https://example.com

      Actual results

      returns i.e. https://example.com:443

      Workaround

      n/a

      Development notes

      The current implementation makes erroneous assumptions. Tests have been added.

        Acceptance criteria

          1.
          		 Review Sub-task Completed Jaroslav Simak
          2.
          		 Implementation Sub-task Completed Unassigned
          3.
          		 PiQA Sub-task Completed Jaroslav Simak
          4.
          		 QA Sub-task Completed Chuong Doan Huy

              jsimak Jaroslav Simak
              pgaschuetz Philipp Gaschuetz
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved:
                Work Started:

                  Bug DoR
                  Task DoD