Uploaded image for project: 'Magnolia CLI'
  1. Magnolia CLI
  2. NPMCLI-89

Remove shim wrapper around "commander" once #name function PR is merged

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Neutral
    • None
    • 2.1.1
    • None

    Description

      Because the commander library doesn't have a chainable setter for the name property, we created a PR on GitHub for that. As a workaround in the meantime, we created a custom node module `commander_shimmed.js`, which provides a wrapper providing desired behavior through a mild hack.

      Once above PR is merged,

      • Delete `commander_shimmed.js`
      • Update commander version in `package.json`
      • Replace all `require`s of `commander_shimmed` by `commander` again

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                creichenbach Cedric Reichenbach
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoR