Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-1017

Remove prefix website when using @name in routeTemplate of site norsu definition

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 6.3.0
    • None
    • None
    • None

      Step to reproduce:

      • Using hello-saas repo here
      • Add new page travel with template basic-with-site to use site aware render type
      • Open travel page detail and see the iframe load correct path:  
      http://cooltravel.com/travel?mgnlPreview=false&mgnlChannel=desktop
      
      • Now change of travel site routeTemplate here  from @path to @name as below
      routeTemplate: '/{language}{{@name}}'
      
      • See iframe path has website workspace as below
      http://cooltravel.com/website/travel?mgnlPreview=false&mgnlChannel=desktop
      

      Expectation: Do not include website in url. Should be like this: http://cooltravel.com/travel?mgnlPreview=false&mgnlChannel=desktop

       

      Hint: May be missing switch case for NAME in DefaultSpaRouter. This is example of Path case in this PR: https://git.magnolia-cms.com/projects/MODULES/repos/pages/pull-requests/486/diff#magnolia-spa-norsu-rendering/src/main/java/info/magnolia/pages/norsu/routing/DefaultSpaRouter.java

        Acceptance criteria

          1. using-name.png
            using-name.png
            449 kB
          2. use-path.png
            use-path.png
            666 kB

              canh.nguyen Canh Nguyen
              oanh.thai Oanh Thai Hoang
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved:
                Work Started:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 4d 2.75h
                    4d 2.75h