Details
-
Improvement
-
Resolution: Fixed
-
Neutral
-
5.4.1
-
None
-
-
Empty show more show less
-
Kromeriz 87
-
5
Description
In the preview mode we have a menu that uses a url fragment identifier (#part) of the url.
This does not work because of some strange url's that are generated:
http://ip169-093.vpro.nl:8085/vpronl-sample/?mgnlPreview=true&mgnlChannel=desktop&mgnlChannel=desktop&mgnlPreview=true#navigation-overlay&mgnlChannel=desktop&mgnlPreview=true
It looks like the code in info.magnolia.ui.vaadin.gwt.client.connector.PageEditorConnector basically adds the parameters to the path:
eventBus.addHandler(FrameNavigationEvent.TYPE, new FrameNavigationEventHandler() {
@Override
public void onFrameUrlChanged(FrameNavigationEvent frameUrlChangedEvent) {
String path = frameUrlChangedEvent.getPath();
final String platformId = getState().parameters.getPlatformType().getId();
path += path.indexOf('?') == -1 ? "?" : "&";
path += "mgnlChannel=" + platformId;
final boolean isPreview = getState().parameters.isPreview();
path += "&mgnlPreview=" + isPreview;
view.setUrl(path);
}
});
This does not allow for url fragment identifiers.
Checklists
Acceptance criteria