Uploaded image for project: 'Magnolia Multisite Module'
  1. Magnolia Multisite Module
  2. MULTISITE-133

New MultiSiteRegistry doesn't limit number of sites according to allowed sites by the license

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Critical Critical
    • 3.0.0
    • None
    • Yes

      MGNLSITE-105 and MULTISITE-122 brings new SiteRegistry, unfortunately they are not limiting number of allowed sites configured in the license.

      Developer notes:
      While implementing the new registry, limitation for number of registered sites was removed. This check was previously done in MultiSiteRegistry#register and MultiSiteRegistry #unregisterAndRegister methods, but these are deprecated and not used with new ConfigurationSource mechanism. Registry doesn't hold the map of registered definition, but delegates into ConfigurationSource(every source holds own RegistryMap), so during the registration it is not possible to know how many definitions are registered by the other ConfigurationSources.
      I also tried to implement SiteCountValdiator and add it via info.magnolia.config.registry.AbstractRegistry#addValidator, but that marked all definitions as problematic, but still registered them.

        Acceptance criteria

              thien.quach Quach Hao Thien
              mdivilek Milan Divilek
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:
                Work Started:

                  Task DoR

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 9.5d
                    9.5d