-
Task
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
Empty show more show less
-
Basel 123, Basel 124, Basel 125, Basel 126
-
13
Following the initial POC done in DEV-676, here are some points that need to be adressed before we implement such a health check:
javax.servlet-api is used in a lot of modules, often declared as unused, but tests fail in some cases if it is not present (~RepositoryTestCase). Investigate if that could be fixed, allowing us to remove the dependency everywhere.those will be ignored thanks to the wildcard rule, they're not really false positive, though - but an investigation into the topic would be a task on its ownjavax.jcr and javax.inject are used almost everywhere but not necessarily explicitely declared. Do we want to have them as part of every POM? Near the bottom?yes, they'll be added. Order TBD exactly in a later stepInvestigate if it is possible with a reasonable effort to have yellow rather than red builds for failing analysis reports.in the implementation phaseIn the backup module, does h2 need to be scoped appropriately (rather than excluded) to no longer be an error?not a scope issue, noReactor vs. parent POM: which responsibilities does each have?no longer relevant AFAICSInvestigate why, in site/site-app, mvn says mockito-core and magnolia-site are superfluous dependencies, which they are not at all. Same with mockito-core in templating-samples.false positives that will be ignored once PR is in placeIn UI, org.vaadin.addon:easyuploads:jar:8.0.0:compile is a false positive in submodules that don't even use it. Investigate.false positive that will be ignored once PR is in placeIn groovy/magnolia-module-groovy, com.google.gwt:gwt-elemental:jar:2.8.1:provided is both a problem if you add or remove it.false positive that will be ignored once PR is in placecom.google.code.findbugs:annotations used in resources and main wasn't added to the BOM but individually to those two projects - apchelintcev thought we might use other impls. of nullability annotations. Also the project seems dead.see BUILD-291usages of the icons project are not caught by Maven. What to do?false positive that will be ignored once PR is in placehow to skip the webapps?this could be done in a Jenkins pipeline file if that's what we end up doing. Let's see in the impl phaseinvestigate comment by Michael below.equivalent to what we're doing
Acceptance criteria
- is related to
-
BUILD-291 Remove ununused com.google.code.findbugs:annotations
- Accepted
-
BUILD-292 Implement Jenkins pipelines for some jobs
- Closed
-
CONTEDIT-163 dam-app and MTK aren't Maven but descriptor dependencies
- Closed