The multi site support, mainly the detection of the site, must be improved.

Use Cases

This is not trivial as we have to support various scenarios:

1) authoring without domain

• detection must work without the domains
• if done by the path the solution conflicts with the i18n support
• add a site parameter: currently done by /sitename/shortURI links

2) i18n

• links might be using the i18n pattern: /de/mypage
• a simple path matching does not work
• multi site filter has to be in front of the i18n filter as the site defines the i18n configuration

3) cross site links

• public: use the domain on public sites if defined
• author: use /sitename/shortURI link

4) subsites

• one can map sites to subpathes
• /section -> /mysite/section

5) virtual uri mappings

• see MGNLETK-27 as an example

6) no domain

• sites don't necessarily have a domain definition
• respect that, this sites can always match

7) sitename and site-root name can be the same

• don't remove the site-root name if it looks like being the sitename

Different ways a page can be accessed (should we reduce that? probably not)

• full path (for instance if opened in the website tree)
• /sitename/shortURI
• domain/shortURI

Solution/Ideas

• write all essential test cases
• use best match strategy
  • domain
  • site
  • mapping
• extract a clean URI method
  • either in the filter or in the sitemanager by introducing a return value object in getAssignedSite(domain, uri)
• tree opens the page by using the link transformer (no conflict with other links)
  • but might not be possible with the current tree
• combine mutlisite detection and i18n detection
  • I don't like this because this just hides the problem and other dynamic link generation might cause the same issue

The relevant Classes:

• info.magnolia.module.extendedtemplatingkit.filters.MultiSiteFilter
• info.magnolia.module.extendedtemplatingkit.ETKLinkTransformerManager
• info.magnolia.module.extendedtemplatingkit.sites.ETKSiteManager