XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • High
    • 1.1.0
    • None
    • None
    • Yes
    • HL & LD 38
    • 2

    Description

      https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/browse/packages/template-annotations/src/service/PersonalizationService.js#67

      .inEditor() will return false for SSR e.g. Next.js

      Maybe we could drop all iframe checks in those editor functions and really purely on query params and extend how inEditor works? (so it works for SSR (reading from request) as well as browser).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                canh.nguyen Canh Nguyen
                bstaryga Bartosz Staryga
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 1.5d
                      1.5d