-
Improvement
-
Resolution: Fixed
-
Major
-
None
-
None
-
None
-
-
Empty show more show less
-
Yes
-
DevX 38, DevX 39, DevX 40, DevX 41, DevX 42
-
0.5
-
Yes
Proposal
I thnk this can maybe be addressed once https://jira.magnolia-cms.com/browse/MGNLFE-232 is merged in.
Explanation
Currently it is necessary to tell the fehelper libraries whether the app is running in the page editor. Developers need to set global.mgnlInPageEditor to true in case rendering green bars for SSR.
The current approach was chosen in the interest of time and to ensure that the developer had the control to set this information no matter what type of environment they are running in.
Now, with this ticket, we invest the time to find a good solution that works with all key anticipated use cases. At least with SSR/Preview on Next, Gatsby, Scully and Nuxt.
See the ticket whhere behavirou was introduced: https://jira.magnolia-cms.com/browse/MGNLFE-118
Key comments:
"I think it's risky to remove the inIframe check now. On nodejs we have the global object that we can add something like mgnlEditMode=true"
"As long as it works in next js (or any other SSR) it's perfect.
We make it work, then we can make it better"
- depends upon
-
MGNLFE-232 Simplify usage of frontend-helpers with magnoliaContext
- Closed
- is caused by
-
MGNLFE-118 p13n support for SSR
- Closed
- mentioned in
-
Page Loading...
1.
|
Implement | Completed | Robert Šiška | |
2.
|
Review | Completed | Phong Le Quoc | |
3.
|
PiQA | Completed | Phong Le Quoc | |
4.
|
QA | Completed | Oanh Thai Hoang | |
5.
|
DOC: SSR | It should not be necessary to tell FEHelpers if it is in the page editor | Completed | Martin Drápela | |
6.
|
DOC: Note that global.mgnlInPageEditor is deprecated | Completed | Martin Drápela |