Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-30

react-editor Page should take a 'config' argument instead of 'componentMappings'

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Neutral Neutral
    • 1.0.1
    • None
    • None
    • None
    • Yes
    • Yes
    • 6.2.1 Ramp-up 21
    • 3

      The React <Page> component should take a 'config' parameter instead of 'componentMappings'. The config parameter is an object, and for now supports only one subproperty - 'componentMappings'.

      Update examples as well.

      Reason:

      The amount of configuration for the SPA libraries will definitely increase as we support additional features, such as personalization, multilanguage, AB-testing and so forth.

      It will save us and project developers trouble if we implement a 'config' argument now which can be the vehicle for the 'componentMappings' , and easily support further parameters later.

      This is a standard pattern for js libraries to accept all configuration in one JS object.

        Acceptance criteria

              sang.ngo Sang Ngo Huu
              czimmermann Christopher Zimmermann
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1d 6.5h
                  1d 6.5h