Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2135

Forms and dialogs are not properly decorated

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 5.1
    • 5.1
    • None
    • None

      When trying to put the new i18n system in place for the workflow module I realised that many keys I expected the system to generate weren't actually generated, for example the keys for save and cancel buttons are never created or the field labels in forms and dialogs. After some investigation, it turned out that forms and dialogs haven't been properly decorated, i.e. the calls to I18nizer.decorate() are either missing or put in the wrong place. After putting them in the right spots so that the whole object hierarchy is properly decorated, the AbstractFormKeyGenerator has started failing with some NPE which need to be fixed. Furthermore, we miss a KeyGenerator for FieldValidatorDefinition(s). The reason why everything apparently works now, i.e. most stuff is basically translated is because translations are currently hardcoded in configuration but once we clean config up and remove labels, descriptions and other i18n properties then the problem would become apparent.

        Acceptance criteria

              fgrilli Federico Grilli
              fgrilli Federico Grilli
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD