-
Improvement
-
Resolution: Won't Do
-
Minor
-
None
-
None
-
None
There's a need for some visual ordering and distinction of buttons of different purposes.
Current setup is quite messy and mixes two semantics for what is a primary and secondary button vs. action. (addPrimaryAction(), addSecondaryAction(), primary-actions, secondary-actions, primary-button, secondary-button...) We have buttons that
- close a dialog (right aligned - in code called unfortunately "primaryActions") and
- confirm (usually green, rightmost, primary-button styled)
- commit
- save
- choose
- ..?
- cancel - no operation (transparent, on the right aligned, but to left of primary, secondary-button styled, even though still a primaryAction)
- confirm (usually green, rightmost, primary-button styled)
- do other actions (left aligned, called "secondaryActions", even though a primary-button can be there)
Places where "secondaryActions" occur:
- Move dialog has three choosing primary-buttons Move before/inside/after and a cancel button. Previously the before after were black, now they are green. Anja wanted to have them white, considering them secondary-buttons. This is still questionable, since all three buttons are essentially equal in the impact of what they do since they move the item, just to different places.
- All three buttons could be together and visually same
- Roman suggested a combo box with options inside/before/after. Maybe cumbersome.
- Asset chooser will have Upload, Upload and edit button. Those are not choosing - what style should they have?
- other?
Further changes in API and how actions should be allowed for extenders to be added and reasonably styled require that we have clear guidelines on what types of actions can be here, how they should look, be styled, ordered, aligned etc.
- is depended upon by
-
MGNLUI-5925 Improve API for adding actions to dialog footers
- Open
- relates to
-
MGNLUI-5951 Restrict green button styling in editor footer layout for the rightest element in primary slot
- Open
- split from
-
MGNLUI-5711 Improve new asset chooser
- Closed