Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-877

Factories should not copy contents of registries into state of their own

    XMLWordPrintable

Details

    • Task
    • Resolution: Obsolete
    • Major
    • 5.0
    • None
    • framework

    Description

      It should be the registries that own the mappings and the factories should query the registry each time. Otherwise changes in a registry has no effect.

      This effects all classes inheriting from MappingFactoryBase.

      • info.magnolia.ui.dialog.action.DialogActionFactoryImpl
      • info.magnolia.ui.form.field.validation.ValidatorFieldFactory
      • info.magnolia.ui.admincentral.mediaeditor.editmode.factory.EditModeProviderFactory
      • info.magnolia.ui.form.field.builder.FieldFactory
      • info.magnolia.ui.form.action.FormActionFactoryImpl

      The class MappingFactoryBase should be removed.

      The lookup of implementation based on the class of the definition needs to go to the registries. We should introduce a base class for this since the logic will be identical for all of them. See MGNLUI-581 for changes pending for this logic.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                tmattsson Tobias Mattsson
                tmattsson Tobias Mattsson
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR