Uploaded image for project: 'Magnolia Templating Essentials'
  1. Magnolia Templating Essentials
  2. MTE-153

Supplied variation [null] could not be found

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Neutral Neutral
    • None
    • 2.0.3
    • imaging
    • None

      In the class VariationAwareImagingSupport if the local variable "variationName" is null the code simply prints "Supplied variation [null] could not be found. Please update your configuration." It would be helpful to know what property it was trying to use at the time. In the context of support someone can give us the feedback --> "I'm seeing this in my log":

      2023-07-03 10:36:11 2023-11-17 17:22:02,650 WARN  ia.templating.imaging.VariationAwareImagingSupport: Supplied variation [null] could not be found. Please update your configuration.
      

      Notes
      Currently the code looks like this:

      @Override
          public String createLink(Property binaryProperty, String variationName) {
              if (isEnabled() && !ImagingSupport.VARIATION_ORIGINAL.equals(variationName)) {
                  if (variations.containsKey(variationName)) {
                      return variations.get(variationName).createLink(binaryProperty);
                  } else {
                      log.warn("Supplied variation [{}] could not be found. Please update your configuration.", variationName);
                  }
              }
      
              return createLink(binaryProperty);
          }
      
      • If the variationName is null or cannot be found then we need to know more information about binaryProperty so we can track it down. Otherwise it ends up being noise in the log file.

        Acceptance criteria

              Unassigned Unassigned
              rgange Richard Gange
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:

                  Task DoD