Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-6398

Remove grid scroll extension

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Neutral
    • 6.2.6
    • 6.2.6
    • None
    • None

    Description

      Timeboxed to 5

      Usage of this extension seems obsolete after MGNLUI-6242 as the grid now scroll to the selected item (tree) or lists selected items at top (list).

      We still use one method though (#adjustColumnWidth).

      We even had to fix issue with this extension, see https://git.magnolia-cms.com/projects/PLATFORM/repos/vaadin-compatibility-addons/browse/vaadin-compatibility-grid-scroll-extension

      Steps to do

      • Removal from framework grids 
      • Removal from FindBar
      • Removal from widgetset
      • (possibly new ticket) remove custom fix in vaadin addons

      Acceptance criteria

      • ensure there are no infinite polls when you open up an app with a grid when any of your workspaces have a lot of data in it.
        • For that, you can use [^pageCreationScript] this script in Groovy Module to fill page workspace with 50000 nodes. Then open up any app, even an empty one, and observe in DevTools that there's infinite polling taking place. It will look very much like in this video [^2020-11-09 10-15-33.mp4] 
      • Ensure no critical functionality was lost with the removal of the extension
      • Also, consider
        • drop maintenance of our custom fix
        • drop dependency to 3rd party widgets 

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                rkovarik Roman Kovařík
                rkovarik Roman Kovařík
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 3.3h
                      3.3h